-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input #1524
Input #1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly what I am looking for as well. This PR looks great
@shubhbapna this pull request has failed checks 🛠 |
dcfa663
@cplee @shubhbapna I resolved the merge conflict, but now is one approval is missing. |
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
==========================================
+ Coverage 61.22% 61.40% +0.18%
==========================================
Files 46 46
Lines 7141 7157 +16
==========================================
+ Hits 4372 4395 +23
+ Misses 2462 2454 -8
- Partials 307 308 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes #1021
Added 2 flags
--input
and--input-file
to manually pass inputsYou will notice that in the
New
function forrunner
, I only set the inputs if event payload was not defined. IMO, if the user is passing a payload, then they can set their input in that json file itself rather than passing it separately using the flags.