Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input #1524

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Input #1524

merged 4 commits into from
Jan 13, 2023

Conversation

shubhbapna
Copy link
Contributor

Fixes #1021

Added 2 flags --input and --input-file to manually pass inputs

You will notice that in the New function for runner, I only set the inputs if event payload was not defined. IMO, if the user is passing a payload, then they can set their input in that json file itself rather than passing it separately using the flags.

@shubhbapna shubhbapna requested a review from a team as a code owner December 19, 2022 20:39
mikerjacobi
mikerjacobi previously approved these changes Dec 28, 2022
Copy link

@mikerjacobi mikerjacobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I am looking for as well. This PR looks great

cplee
cplee previously approved these changes Jan 10, 2023
ChristopherHX
ChristopherHX previously approved these changes Jan 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2023

@shubhbapna this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jan 13, 2023
@ChristopherHX ChristopherHX dismissed stale reviews from cplee, mikerjacobi, and themself via dcfa663 January 13, 2023 19:10
@ChristopherHX
Copy link
Contributor

@cplee @shubhbapna I resolved the merge conflict, but now is one approval is missing.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #1524 (dcfa663) into master (4989f44) will increase coverage by 0.18%.
The diff coverage is 70.27%.

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   61.22%   61.40%   +0.18%     
==========================================
  Files          46       46              
  Lines        7141     7157      +16     
==========================================
+ Hits         4372     4395      +23     
+ Misses       2462     2454       -8     
- Partials      307      308       +1     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.58% <ø> (ø)
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/container/docker_auth.go 51.35% <56.25%> (+3.73%) ⬆️
pkg/runner/runner.go 86.45% <66.66%> (-2.05%) ⬇️
pkg/container/docker_build.go 59.49% <100.00%> (+0.51%) ⬆️
pkg/runner/command.go 94.16% <100.00%> (+1.73%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Jan 13, 2023
@mergify mergify bot merged commit 767e6a8 into nektos:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: A flag for providing inputs
4 participants