fix: allow override of artifact server bind address #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prior to this change, the artifact server always binds to the detected "outbound IP", breaks functionality when that IP is unroutable. For example, Zscaler assigns the host a local CGNAT address, 100.64.0.1, which is unreachable from Docker Desktop. * Add the `--artifact-server-addr` flag to allow override of the address to which the artifact server binds, defaulting to the existing behaviour. Fixes: #1559
KnisterPeter
approved these changes
Jan 16, 2023
|
@isometry this pull request has failed checks 🛠 |
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
+ Coverage 61.22% 61.44% +0.22%
==========================================
Files 46 46
Lines 7141 7156 +15
==========================================
+ Hits 4372 4397 +25
+ Misses 2462 2452 -10
Partials 307 307
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@KnisterPeter : anything else I need to do to get this merged? |
|
More approvals from maintainers are required. Just wait a bit longer. |
ChristopherHX
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--artifact-server-addrflag to allow override of the address to which the artifact server binds, defaulting to the existing behaviour.Fixes #1559