Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the comment-out code #1691

Merged
merged 2 commits into from Apr 19, 2023
Merged

Conversation

M-Yamashita01
Copy link
Contributor

We removed the comment-out code, which relates to #831.

@M-Yamashita01 M-Yamashita01 requested a review from a team as a code owner March 20, 2023 22:17
@M-Yamashita01 M-Yamashita01 force-pushed the remove-dead-code branch 2 times, most recently from c630b32 to b1f2cf8 Compare March 21, 2023 22:16
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1691 (98945b0) into master (4989f44) will increase coverage by 1.07%.
The diff coverage is 66.12%.

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
+ Coverage   61.22%   62.30%   +1.07%     
==========================================
  Files          46       48       +2     
  Lines        7141     7579     +438     
==========================================
+ Hits         4372     4722     +350     
- Misses       2462     2527      +65     
- Partials      307      330      +23     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.99% <0.00%> (+0.40%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

@M-Yamashita01 this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Apr 19, 2023
@mergify mergify bot removed the needs-work Extra attention is needed label Apr 19, 2023
@mergify mergify bot merged commit 35d6e9f into nektos:master Apr 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants