fix: remove hardcoded reference to github.com when using reusable remote workflows and remote actions #1784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1588
By removing reference to the hardcoded
github.com
and instead usingserverURL
from github context, we can start controlling where we clone these actions/workflows from. So for example if we wantact
to use ssh then we can simply pass the following option:Moreover, I noticed that for reusable workflows we are cloning the repositories in a directory named -
{owner}-{repo}-.github-workflows-{filename}@{ref}
. However if we change this directory name to be{owner}-{repo}@{ref}
, we will be able to reduce the number of clonesact
will make when using multiple reusable workflows from the same repository.