-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add support for github action variables #1833
feature: Add support for github action variables #1833
Conversation
8480e7e
to
d6a38d4
Compare
@wildsheepz this pull request has failed checks 🛠 |
Codecov Report
@@ Coverage Diff @@
## master #1833 +/- ##
==========================================
+ Coverage 61.22% 62.68% +1.46%
==========================================
Files 46 51 +5
Lines 7141 8193 +1052
==========================================
+ Hits 4372 5136 +764
- Misses 2462 2671 +209
- Partials 307 386 +79
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@KnisterPeter, the |
@wildsheepz this pull request has failed checks 🛠 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add // nolint:gocyclo
above evaluateVariable. Idk if the other maintainer want to enforce a split of the function.
I don't insist that you remove the Syntax extension, do whatever you think is good to go with.
FYI However as long the checks are red, only the owner cplee can bypass them. Otherwise you need two approvals.
6a0b577
to
b41728b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing this.
BTW you can do --var-file vars.yml
and use well known yml syntax to define vars.
Co-authored-by: ChristopherHX <christopher.homberger@web.de>
@cplee This change is merged but only available on the master. Can we get a new release for this feature please? |
Version was bumped over the weekend however the release workflow run failed. |
Because the upstream [PR](nektos#1833) already supports variables, so this PR revert nektos#43 (commit de52913), and cherry-pick commit [6ce45e3](nektos@6ce45e3). Co-authored-by: Kuan Yong <wong0514@gmail.com> Reviewed-on: https://gitea.com/gitea/act/pulls/66 Reviewed-by: Jason Song <i@wolfogre.com> Co-authored-by: sillyguodong <gedong_1994@163.com> Co-committed-by: sillyguodong <gedong_1994@163.com>
Adding support for GitHub actions variables. eg.
vars.ExampleVar
in workflows.#1558