New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: correctly use the xdg library, which has the side effect to fix the config survey #2195
feat: correctly use the xdg library, which has the side effect to fix the config survey #2195
Conversation
… the config survey
@mrnossiom this pull request has failed checks 🛠 |
CI doesn't pass due to unrelated 404 hit in Codecov action |
5a27192
to
0dfaa43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2195 +/- ##
=======================================
Coverage 61.56% 61.56%
=======================================
Files 53 53
Lines 9002 9002
=======================================
Hits 5542 5542
Misses 3020 3020
Partials 440 440 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows is fixed
… the config survey (nektos#2195)
Fixes: #2193
It worked before my PR merge commit, and does not after... I guess it's my fault 😄.
Fix
The
os.Create
call indefaultImageSurvey
errors in case we could not create the file, like in the situation the parent folder wasn't created.Also
configLocations
would setactrcXdg
only if a file was actually found. So the path would be empty on first launch.Instead of manually creating the parent folder, I went the way of modifying
configLocations
to include the correct xdg lib calls that takes cares of creating the folder and returning the right path.Thanks and sorry again