Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify go-git cache #2208

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

ChristopherHX
Copy link
Contributor

Doing a refs/*/ fetch seems unnecassary, short shas are rejected by the git protocol.

This fixes using HEAD as action version and let git decide to prefer tag over branch name using short form

Also reduces complexity.

Fixes #2206

Includes extended test cases and no longer fetches a repository from my account.

@ChristopherHX ChristopherHX requested a review from a team as a code owner February 6, 2024 13:08
Copy link
Contributor

github-actions bot commented Feb 6, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.33s
✅ REPOSITORY git_diff yes no 0.12s
✅ REPOSITORY grype yes no 7.34s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY trivy-sbom yes no 0.61s
✅ REPOSITORY trufflehog yes no 7.36s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

mergify bot commented Feb 6, 2024

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Feb 6, 2024
@ChristopherHX ChristopherHX changed the title refactor: simpilfy go-git cache refactor: simplify go-git cache Feb 7, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (5a80a04) 61.56% compared to head (2d3e685) 61.66%.
Report is 14 commits behind head on master.

Files Patch % Lines
pkg/runner/action_cache_offline_mode.go 0.00% 22 Missing ⚠️
pkg/container/docker_socket.go 85.52% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
+ Coverage   61.56%   61.66%   +0.10%     
==========================================
  Files          53       55       +2     
  Lines        9002     9078      +76     
==========================================
+ Hits         5542     5598      +56     
- Misses       3020     3041      +21     
+ Partials      440      439       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the needs-work Extra attention is needed label Feb 12, 2024
@mergify mergify bot merged commit 5601fb0 into master Feb 18, 2024
10 checks passed
@mergify mergify bot deleted the refactor-simplify-go-git-action-cache branch February 18, 2024 03:53
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--use-new-action-cache doesn't handle HEAD
2 participants