Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variadic version of hashFiles #411

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

Bigpet
Copy link
Contributor

@Bigpet Bigpet commented Nov 9, 2020

fixes #324

I don't know any Go, so double check this.

No idea if this needs some file dedup or if the hashes match the GitHub Actions version, this is just to make sure the same *.yaml code doesn't fail in act while it works in the GH Actions runner

@Bigpet Bigpet requested a review from cplee as a code owner November 9, 2020 16:00
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@cplee cplee merged commit d5b2d60 into nektos:master Nov 9, 2020
@Bigpet Bigpet deleted the hashFilesMultiParam branch November 9, 2020 17:22
@CODY-RAY
Copy link

@Bigpet it seems to break when there is a . in the file name

DEBU[0015] Evaluating 'hashFiles('**/package-lock['json']')' instead of 'hashFiles('**/package-lock.json')' ERRO[0015] Unable to interpolate string '${{ hashFiles('**/package-lock.json') }}' - [(anonymous): Line 1:29 Unexpected identifier (and 2 more errors)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hashFiles documentation says you can supply multiple paths, but act doesn't let you
3 participants