Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow files/directories in .gitignore to be copied to container #537

Merged
merged 2 commits into from
May 3, 2021

Conversation

catthehacker
Copy link
Member

Continuation of #198
Fixes #193
Fixes #325

pkg/runner/run_context.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

PR is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added the stale label Mar 26, 2021
@catthehacker catthehacker force-pushed the enable-disable-gitignore branch 2 times, most recently from 18fbae2 to 12c3e8a Compare March 26, 2021 14:16
@wagenet
Copy link

wagenet commented Mar 26, 2021

I think we still need this.

@github-actions github-actions bot removed the stale label Mar 27, 2021
@cplee
Copy link
Contributor

cplee commented Mar 29, 2021

@catthehacker - i'm ready to merge this once conflicts are resolved

@cplee cplee added the needs-work Extra attention is needed label Mar 29, 2021
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catthehacker - looks like there was a regression here. We are back to the disallowGitIgnore on command line but then useGitIgnore internally

@github-actions
Copy link
Contributor

PR is stale and will be closed in 14 days unless there is new activity

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #537 (4a7a846) into master (f32babb) will decrease coverage by 0.04%.
The diff coverage is 20.00%.

❗ Current head 4a7a846 differs from pull request most recent head c8f238a. Consider uploading reports for the commit c8f238a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   49.39%   49.35%   -0.05%     
==========================================
  Files          23       23              
  Lines        2318     2320       +2     
==========================================
  Hits         1145     1145              
- Misses       1046     1048       +2     
  Partials      127      127              
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.92% <0.00%> (-0.02%) ⬇️
pkg/runner/runner.go 94.28% <ø> (ø)
pkg/runner/run_context.go 77.41% <100.00%> (ø)
pkg/runner/step_context.go 70.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32babb...c8f238a. Read the comment docs.

@cplee cplee merged commit 7ae9916 into nektos:master May 3, 2021
@catthehacker catthehacker deleted the enable-disable-gitignore branch May 7, 2021 10:45
@catthehacker catthehacker removed the needs-work Extra attention is needed label Aug 28, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Aug 28, 2021
@davetapley
Copy link
Contributor

Just to be 100% sure: --use-gitignore never made it in, right?

@catthehacker
Copy link
Member Author

Just to be 100% sure: --use-gitignore never made it in, right?

@davetapley it's merged
image

@davetapley
Copy link
Contributor

@catthehacker oh, don't know how I missed that in --help 🙈

That said, it doesn't seem to work, I'll see if I can get a repro.

@catthehacker
Copy link
Member Author

--use-gitignore=false, other syntax may be flaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work Extra attention is needed size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker cp step fails with Python venv inside project directory .gitignore should be ignored for actions
5 participants