-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to allow files/directories in .gitignore
to be copied to container
#537
Conversation
PR is stale and will be closed in 14 days unless there is new activity |
18fbae2
to
12c3e8a
Compare
I think we still need this. |
@catthehacker - i'm ready to merge this once conflicts are resolved |
12c3e8a
to
cf41888
Compare
cf41888
to
ff5f4d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@catthehacker - looks like there was a regression here. We are back to the disallowGitIgnore on command line but then useGitIgnore internally
PR is stale and will be closed in 14 days unless there is new activity |
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 49.39% 49.35% -0.05%
==========================================
Files 23 23
Lines 2318 2320 +2
==========================================
Hits 1145 1145
- Misses 1046 1048 +2
Partials 127 127
Continue to review full report at Codecov.
|
4a7a846
to
d193214
Compare
d193214
to
c8f238a
Compare
@catthehacker this pull request has failed checks 🛠 |
Just to be 100% sure: |
@davetapley it's merged |
@catthehacker oh, don't know how I missed that in That said, it doesn't seem to work, I'll see if I can get a repro. |
|
Continuation of #198
Fixes #193
Fixes #325