adding UTF-8 output codepage support on Windows #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what does this enable/fix? |
|
If Windows is in a language with diacritics, API errors appear incorrectly unless app changes output codepage first to unicode (65001). Actually, since you are using zig master, you may include kernel32 instead of the extern declaration, I already submitted a PR to master adding the function, and it was merged. |
|
are there any docs on this from MS and can you link the upstream pr? |
|
I further simplified the fix, after noticing that |
|
the ci failure is a bug with the other code and the ci script, I'll fix that this change looks good |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.