Moving annotation extraction into tagged Handlers #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Seems to be similar to #107 |
| $definition = $container->getDefinition( | ||
| 'nelmio_api_doc.extractor.api_doc_extractor' | ||
| ); | ||
| $taggedServices = $container->findTaggedServiceIds( |
There was a problem hiding this comment.
This is wrong. You are only accessing tagged services of NelmioApiDocBundle bundle here. If you want to access it for any bundle, you need to use a compiler pass.
|
Thx @stof for all your comments. I've just implementend all of its. |
| /* | ||
| * This file is part of the Sonata project. | ||
| * | ||
| * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org> |
|
Oups ^^ |
|
looks good 👍 |
| @@ -16,6 +16,7 @@ | |||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | |||
| use Symfony\Component\Config\Definition\Processor; | |||
| use Symfony\Component\Config\FileLocator; | |||
| use Symfony\Component\DependencyInjection\Reference; | |||
| namespace Nelmio\ApiDocBundle\Extractor; | ||
|
|
||
| use Nelmio\ApiDocBundle\Annotation\ApiDoc; | ||
|
|
willdurand
added a commit
that referenced
this pull request
Apr 17, 2013
Moving annotation extraction into tagged Handlers
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just code refactoring, extracting the custom annotations parsing to specific handlers, which are services.
Anyone can easily add new Annotation support providing a new handler, as it use tagged services.