Fix Symfony\Component\PropertyInfo\Type::getCollectionValueType() deprecation notice for symfony >=5.3 #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
Aug 18, 2021
There was a problem hiding this comment.
Thank you for submitting this PR, it's really great!
Similarly to what Symfony does, we do our best to keep our code compatible with a wide range of dependency versions when doing changes. In the context of this change, the new method getCollectionValueTypes was introduced in Symfony 5.3 and we still support Symfony 4, so we need to do some more work to support both versions, while fixing these annoying deprecation notices for users :)
…recation notice for symfony >=5.3
onatskyy
force-pushed
the
fix_getCollectionValueType_deprecation
branch
from
ec96853
to
0667881
Compare
|
Great! Thank you @onatskyy :) |
MrBulkinAleksey
added a commit
to MrBulkinAleksey/NelmioApiDocBundle
that referenced
this pull request
Nov 3, 2021
Apply nelmio#1863 to 3.x branch
GuilhemN
pushed a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1856