-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zircore/swagger-php 4.0 #1916
Conversation
Thanks for submitting this PR! It looks like they introduced some more changes, notably |
@GuilhemN I'm sorry for being flippant at first. Fixed, and all the tests are passing with v4. But the code is backwards incompatible with the v3 version of zircotte/swagger-php. Do I still have to fix it to get it back compatible with v3? Or will nelmio/api-doc-bundle also have a major version? Sorry for probably stupid question, I just haven't yet come up with an elegant solution to support both versions. |
No worry, it is very nice of you to start this pull request, I appreciate it very much :) I believe bumping our requirement on zircote/swagger-php to 3.2.0 should be enough, isn't it? (changes in the API were normally done in this version, see zircote/swagger-php@c5f0819) |
@GuilhemN you are right. But I also had to add compatibility layer with 3.2 because of $context property which was moved to another class in 4.0. You can review it now :) |
Thank you! It's a very promising change :) |
Which is introducing php 8.1 attributes support