Fix enum backing type always 'string' #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palgalik
approved these changes
Sep 12, 2023
DjordyKoert
reviewed
Sep 15, 2023
| $schema->type = 'integer'; | ||
| } else { | ||
| $schema->type = 'string'; | ||
| } | ||
| $schema->type = is_subclass_of($enumClass, \IntBackedEnum::class) ? 'int' : 'string'; |
There was a problem hiding this comment.
I'm not really a fan of the if-else combined with the multi places where $schema->type gets set.
Suggested change
| $schema->type = is_subclass_of($enumClass, \IntBackedEnum::class) ? 'int' : 'string'; | |
| $schema->type = is_subclass_of($enumClass, \IntBackedEnum::class) || ($reflectionEnum->isBacked() && 'int' === $reflectionEnum->getBackingType()->getName()) | |
| ? 'integer' | |
| : 'string'; |
|
Also please rebase on master for CI |
|
Thank you @DidierLmn! |
|
I kinda lost track of this one. Thanks a lot for finishing it off and merging @DjordyKoert!! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every enum will be described as type "string" because the current logic to determine the backing type does not work
These are always false, regardless of backing type as you can see at https://3v4l.org/fButY
Moreover the type would be set as "int", which is not valid in OpenApi-Spec.
This MR ensures proper backing detection of enums and sets int-backed enums to type "integer".