Support CSRF protection token of Symfony's form component #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuilhemN I'd be really happy if you could have a look at this addition. |
stollr
force-pushed
the
form_csrf_support
branch
from
b7e3636
to
d3a4bfc
Compare
stollr
force-pushed
the
form_csrf_support
branch
from
d3a4bfc
to
467ef2d
Compare
|
I would also like to see a functional test for this https://github.com/nelmio/NelmioApiDocBundle/tree/master/Tests/Functional/Form 😄 |
stollr
force-pushed
the
form_csrf_support
branch
from
f97e7c4
to
6eaf3fe
Compare
|
@DjordyKoert I have added a functional test, now. |
|
Thank you, could you please also write a test which shows the behaviour when using |
|
@DjordyKoert I have added some edge case handling and more tests. What do you think now? |
|
Thank you @stollr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of the CSRF protection token which is created by the Symfony form component if the
csrf_protectionoption is enabled.As soon as this option is enabled a corresponding property will be added to the schema.
This PR addresses #2120.
There already was another PR (#411) some years ago, but it wasn't merged. I'd be happy if this could be accepted.