Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate non-nullable properties on model as required #2141

Merged

Conversation

DjordyKoert
Copy link
Collaborator

Fix for issue: #2111

@DjordyKoert DjordyKoert force-pushed the feat/2111-set-required-fields-on-object branch from 1aa3759 to a387f9c Compare October 27, 2023 14:03
@DjordyKoert
Copy link
Collaborator Author

failing PHPUnit (8.1, 6.3.*) is unrelated.

@DjordyKoert DjordyKoert force-pushed the feat/2111-set-required-fields-on-object branch from 9e0e52c to 534be18 Compare October 27, 2023 14:30
@DjordyKoert DjordyKoert force-pushed the feat/2111-set-required-fields-on-object branch from ff9d18b to daadd14 Compare October 27, 2023 14:51
@DjordyKoert DjordyKoert marked this pull request as ready for review October 27, 2023 14:55
@DjordyKoert DjordyKoert changed the title Add Schema param to PropertyDescriberInterface Generate non-nullable properties on model as required Oct 30, 2023
@DjordyKoert
Copy link
Collaborator Author

@GuilhemN any chance you can look at this? 😄

@DjordyKoert DjordyKoert merged commit 0dae4c0 into nelmio:master Jan 2, 2024
12 checks passed
@DjordyKoert DjordyKoert deleted the feat/2111-set-required-fields-on-object branch January 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant