Fix wrong detection of OA min/max for symfony contraints with datetime strings #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings If the constraints contain a comparison value that is not int (e.g. datetime string), we cannot infer a OpenAPI value for it. This falsely casted those to int resulting in nonesense like minimum=0 and maximum=0 for string values.
|
Looks good. could you also write a test for the situation where a string is passed to any of these attributes? |
|
Thanks @Tobion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony range and comparison constraints can compare datetime strings, see https://github.com/symfony/validator/blob/0dbfc4b9b87a0e8245ff37d85cbe6b6ef677999f/Constraints/AbstractComparisonValidator.php#L68
If the constraints contain a comparison value that is not int (e.g. datetime string), we cannot infer a OpenAPI value for it. Previously it falsely casted those to int resulting in nonesense like minimum=0 and maximum=0 for string values.