fix(#2222): Fix properties with default values getting marked as required

[DominicLuidold]

Q	A
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #2222

This PR fixes the following two bugs:

• Promoted properties with a value initialized by the constructor are not considered to have a default value and are therefore not returned by ReflectionClass::getDefaultProperties().¹
• The SymfonyConstraintAnnotationReader::processPropertyAnnotations() method is called before a property's default value is set and additionally doesn't consider a possible set default value.

Footnotes

1. https://bugs.php.net/bug.php?id=81386 ↩

[DominicLuidold]

@DjordyKoert tests are failing with PHP 7.4 because of the promoted constructor properties syntax in the two newly added test entities. Do you have an approach in mind how to prevent those failures?

I've thought of wrapping the entity classes and the methods within the ApiControllers with if (PHP_VERSION_ID >= 80000) { but I'm not sure if that's the correct approach here.. 🤔

[DjordyKoert]

@DjordyKoert tests are failing with PHP 7.4 because of the promoted constructor properties syntax in the two newly added test entities. Do you have an approach in mind how to prevent those failures?

I've thought of wrapping the entity classes and the methods within the ApiControllers with if (PHP_VERSION_ID >= 80000) { but I'm not sure if that's the correct approach here.. 🤔

I think it's okay to simply wrap the entity class (EntityWithPromotedPropertiesWithDefaults80) with an if-else statement and create an empty class for PHP 7.4, the class should and cannot be tested on 7.4 anyway

[DominicLuidold]

@DjordyKoert Thanks for your fast response and the code review/input! I've addressed all the open points and was also able to get the tests running with PHP 7.4. 😊

Unfortunately, the test now fails on PHP 8.0 only and I really can't get my head around why. According to the job log, the EntityWithPromotedPropertiesWithDefaults80 is declared more than once:

PHP Fatal error:  Cannot declare class EntityWithPromotedPropertiesWithDefaults80, because the name is already in use in /home/runner/work/NelmioApiDocBundle/NelmioApiDocBundle/tests/Functional/Entity/EntityWithPromotedPropertiesWithDefaults80.php(17) : eval()'d code on line 4

But this isn't the case. I've also manually checked the code beforehand and as far as I'm concerned, it should work. See https://3v4l.org/d0p5L#v8.0.30 with no error output. Am I missing something obvious here? 🤔 😅

[DjordyKoert]

@DjordyKoert Thanks for your fast response and the code review/input! I've addressed all the open points and was also able to get the tests running with PHP 7.4. 😊

Thank you!

Unfortunately, the test now fails on PHP 8.0 only and I really can't get my head around why. According to the job log, the EntityWithPromotedPropertiesWithDefaults80 is declared more than once:

PHP Fatal error:  Cannot declare class EntityWithPromotedPropertiesWithDefaults80, because the name is already in use in /home/runner/work/NelmioApiDocBundle/NelmioApiDocBundle/tests/Functional/Entity/EntityWithPromotedPropertiesWithDefaults80.php(17) : eval()'d code on line 4

But this isn't the case. I've also manually checked the code beforehand and as far as I'm concerned, it should work. See 3v4l.org/d0p5L#v8.0.30 with no error output. Am I missing something obvious here? 🤔 😅

I got no idea why your setup wouldn't work but I have moved this this to its own controller instead of building more onto the ApiController..

[DjordyKoert]

@DominicLuidold could you see if I missed anything by any chance? 😄

[DominicLuidold]

Just two nit-picky things. Thanks a lot for your support @DjordyKoert! 🙏

[DjordyKoert]

Thank you very much @DominicLuidold!