Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan installation #2249

Merged
merged 34 commits into from
Apr 6, 2024
Merged

phpstan installation #2249

merged 34 commits into from
Apr 6, 2024

Conversation

DjordyKoert
Copy link
Collaborator

@DjordyKoert DjordyKoert commented Mar 30, 2024

Q A
Bug fix? no
New feature? no
Deprecations? no
Issues

Adds PHPStan + fixes for associated PHPStan level

  • Level 0
  • Level 1
  • Level 2
  • Level 3
  • Level 4
  • Level 5

Will be done in a separate PR because of the amount of changes

  • Level 6
  • Level 7
  • Level 8
  • Level 9

Extra's

  • Cleaned up ControllerReflector class
    • Removed code related to (unsupported) Symfony < 4
    • Early returns
    • Return types for methods
    • Removed usage of unreachable ClassUtils

Copy link
Contributor

@DominicLuidold DominicLuidold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DjordyKoert I hope you don't mind some input even though your PR is still marked as a draft. Also, it looks more than it is 😅

Thanks for implementing PHPStan! 😄

phpstan.neon Outdated Show resolved Hide resolved
phpstan.neon Outdated Show resolved Hide resolved
phpstan.neon Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
phpstan.neon Outdated Show resolved Hide resolved
@DjordyKoert DjordyKoert marked this pull request as ready for review April 5, 2024 17:14
Copy link
Contributor

@DominicLuidold DominicLuidold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort - I really think this will help the bundle long term! 😄

I only found some very minor things 🙂

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
phpstan.dist.neon Outdated Show resolved Hide resolved
src/Describer/OpenApiPhpDescriber.php Outdated Show resolved Hide resolved
phpstan.dist.neon Show resolved Hide resolved
DjordyKoert and others added 9 commits April 6, 2024 13:42
Co-authored-by: Dominic Luidold <DominicLuidold@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
# Conflicts:
#	tests/Functional/TestKernel.php
@DjordyKoert
Copy link
Collaborator Author

Great effort - I really think this will help the bundle long term! 😄

I only found some very minor things 🙂

Thank you very much for reviewing this 😄

@DjordyKoert DjordyKoert merged commit fc5d60d into nelmio:master Apr 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants