-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpstan installation #2249
phpstan installation #2249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DjordyKoert I hope you don't mind some input even though your PR is still marked as a draft. Also, it looks more than it is 😅
Thanks for implementing PHPStan! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort - I really think this will help the bundle long term! 😄
I only found some very minor things 🙂
Co-authored-by: Dominic Luidold <DominicLuidold@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
# Conflicts: # tests/Functional/TestKernel.php
Thank you very much for reviewing this 😄 |
Adds PHPStan + fixes for associated PHPStan level
Will be done in a separate PR because of the amount of changes
Level 6Level 7Level 8Level 9Extra's
ControllerReflector
classClassUtils