Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for deprecated method enterScope() in DumpCommand #768

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Check for deprecated method enterScope() in DumpCommand #768

merged 1 commit into from
Dec 16, 2015

Conversation

SHyx0rmZ
Copy link
Contributor

The dump command uses ContainerInterface::enterScope, which was deprecated in Symfony 2.8 and removed in 3.0.

@aurimasniekis
Copy link

+1

1 similar comment
@da-wen
Copy link

da-wen commented Dec 16, 2015

+1

@willdurand
Copy link
Collaborator

Does the command still work with this fix?

@da-wen
Copy link

da-wen commented Dec 16, 2015

Yes, it works. I fixed it yesterday in my vendor code and the html will be generated as usual.

@willdurand
Copy link
Collaborator

perfect then. thanks!

willdurand added a commit that referenced this pull request Dec 16, 2015
Check for deprecated method enterScope() in DumpCommand
@willdurand willdurand merged commit 1ae2cfa into nelmio:master Dec 16, 2015
@willdurand
Copy link
Collaborator

This fix will be shipped in 2.11.2.

@da-wen
Copy link

da-wen commented Dec 16, 2015

thx a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants