Escape quotes in sandbox placeholders #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the testsuite relies on SensioFrameworkExtraBundle 3.x which requires Symfony 2.3+. Given that 2.1 and 2.2 are EOLed, removing them from Travis is simpler than updating the testsuite to support them.
Remove EOLed Symfony versions from Travis
Add highlight index.md
Don't let empty arrays get passed through as defaults.
Update parser to convert empty array defaults to null
… SwaggerFormatter
Fix parsing of filters, default values and base path in SwaggerFormatter
Add support for LocalStorage
…ameters-for-put-requests Fix no required parameters for PUT requests
Honor body format before uploading file type parameters
…Made sure that FieldErrors is not duplicated.
FOSRest integration: Form errors format
Display select to choose http method in sandbox
proofread the index
Fix the PhpDoc Handler for `@link` annotation and add tests
suggested change in nelmio#353 is not working
(avoid triggering warning on IDEs like PhpStorm
Fixed type annotations
Allow custom ApiDoc annotation
Headers support
Fix wrapping of format table row
Links from index.rst to the other doc files
Fixed the links to some doc articles
…L API doc. Fixes issue nelmio#864.
Usage of OUTPUT_RAW to avoid javascript syntax error when dumping HTML
…-empty nelmio#502 hide requirement when empty
Add navigation index for resources
Allow filter descriptions to be used in conjunction with POST/PUT inp…
Key "statusCodes" for array with keys "method, uri, description, documentation, filters, requirements, parsedResponseMap, https, authentication, authenticationRoles, deprecated, id" does not exist in NelmioApiDocBundle::method.html.twig at line 182.
Sample:
/**
* Retrieves the list of categories (paginated) based on criteria.
*
* @apidoc(
* resource=true,
* output={"class"="Sonata\DatagridBundle\Pager\PagerInterface", "groups"={"sonata_api_read"}}
* )
*
*
* @QueryParam(name="page", requirements="\d+", default="1", description="Page for category list pagination")
* @QueryParam(name="count", requirements="\d+", default="10", description="Number of categories by page")
* @QueryParam(name="enabled", requirements="0|1", nullable=true, strict=true, description="Enabled/Disabled categories filter")
* @QueryParam(name="context", requirements="\S+", nullable=true, strict=true, description="Context of categories")
*
* @view(serializerGroups="sonata_api_read", serializerEnableMaxDepthChecks=true)
*
* @param ParamFetcherInterface $paramFetcher
*
* @return PagerInterface
*/
Fix error: Key "statusCodes" for array with keys...
Fixed placeholder translations nelmio#889
Previously, having a placeholder with `"`'s passed lead to HTML attributes getting broken. The first `"` would just close the attribute, and the placeholder would get broken. Now, all placeholders should only have `"`s instead of `'`'s, and the `placeholder` HTML attr is correctly escaped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, having a placeholder with
"'s passed lead to HTML attributes getting broken. The first"would just close the attribute, and the placeholder would get broken:After this fix all placeholders should only have
"s instead of''s, and theplaceholderHTML attr is correctly escaped.