Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root node deprecation in symfony/config > 4.1 #112

Merged
merged 1 commit into from Dec 11, 2018

Conversation

mdeboer
Copy link
Contributor

@mdeboer mdeboer commented Dec 3, 2018

Fixes the deprecation warnings about tree builders without root nodes being deprecated since 4.2. This fix is BC with 4.1 and older and is similar to the fix applied to doctrine/DoctrineBundle.

Fixes the deprecation warnings about tree builders without root nodes being deprecated since 4.2. This fix is BC with 4.1 and older and is similar to the fix applied to doctrine/DoctrineBundle.
@mdeboer mdeboer changed the title Fix root node deprecation in symfony-config > 4.1 Fix root node deprecation in symfony/config > 4.1 Dec 3, 2018
@pau1z
Copy link

pau1z commented Dec 11, 2018

Can you please merge this? :)

@Seldaek Seldaek merged commit c8c1d99 into nelmio:master Dec 11, 2018
@mdeboer mdeboer deleted the fix-config-deprecation branch December 11, 2018 17:42
@mdeboer
Copy link
Contributor Author

mdeboer commented Dec 11, 2018

Thank you for merging! 🎉

@zoka123
Copy link

zoka123 commented Feb 5, 2019

@Seldaek It would be great if we could have a release with this PR merged.

I believe you're busy, let me know if I can help you with preparing that release somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants