rework forced_allow_origin_value option to always set the header #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Seldaek I updated the PR, now it won't change anything for those who don't use the |
jb-reynaud
approved these changes
Jan 12, 2017
|
Thanks, 1.5.1 is out https://github.com/nelmio/NelmioCorsBundle/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #66 (cache issues)
Because the
forced_allow_origin_valueoption is only useful for the cache issues... but it doesn't solve it yet.Note: As @Seldaek said, we could also set a
Vary: Originheader to workaround the cache issues instead of merging this PR (if the cache system supports it).