Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework forced_allow_origin_value option to always set the header #72

Merged
merged 1 commit into from Jan 22, 2017
Merged

rework forced_allow_origin_value option to always set the header #72

merged 1 commit into from Jan 22, 2017

Conversation

@Oliboy50
Copy link
Contributor

@Oliboy50 Oliboy50 commented Jan 3, 2017

Fix #66 (cache issues)

Because the forced_allow_origin_value option is only useful for the cache issues... but it doesn't solve it yet.

Note: As @Seldaek said, we could also set a Vary: Origin header to workaround the cache issues instead of merging this PR (if the cache system supports it).

@Oliboy50
Copy link
Contributor Author

@Oliboy50 Oliboy50 commented Jan 4, 2017

@Seldaek I updated the PR, now it won't change anything for those who don't use the forced_allow_origin_value option.
Could be a v1.5.1 don't you think so? 😄

@Seldaek Seldaek merged commit 3c7a643 into nelmio:master Jan 22, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Jan 22, 2017

@Oliboy50 Oliboy50 deleted the Oliboy50:rework-forced-option branch Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants