Add support for Symfony 7 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps the min PHP version to 7.2 because Symfony 7 requires adding a return type and this requires support for variance rules to stay compatible with older Symfony versions, which are available only in PHP 7.2+.
stof
commented
Dec 14, 2023
| if (method_exists($treeBuilder, 'getRootNode')) { | ||
| $rootNode = $treeBuilder->getRootNode(); | ||
| } else { | ||
| // BC layer for symfony/config 4.1 and older |
There was a problem hiding this comment.
I cleaned this because the min version in the composer.json is symfony/config 4.4
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the min PHP version to 7.2 because Symfony 7 requires adding a return type and this requires support for variance rules to stay compatible with older Symfony versions, which are available only in PHP 7.2+.