Decouple UA analyzer and parser to allow caching #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->booleanNode('enabled') | ||
| ->defaultFalse() | ||
| ->end() | ||
| ->scalarNode('service') |
There was a problem hiding this comment.
might be parser instead of service
|
Don't forget to update README |
romainneutron
force-pushed
the
cached-ua-parser
branch
2 times, most recently
from
7ee18f2
to
9acd532
Compare
|
|
||
| $name = $this->parser->getUaFamily($userAgent); | ||
|
|
||
| if (null !== $item) { |
There was a problem hiding this comment.
This will store the result only when there was an exception, but not when there was no hit.
romainneutron
force-pushed
the
cached-ua-parser
branch
2 times, most recently
from
00ff590
to
2ff8c36
Compare
romainneutron
force-pushed
the
cached-ua-parser
branch
from
2ff8c36
to
57e586b
Compare
|
Just pushed a final version with README updated. Comments are welcome |
| private $lifetime; | ||
| private $prefix; | ||
|
|
||
| public function __construct(CacheItemPoolInterface $cache, UAFamilyParser $parser, $lifetime = 0, $prefix = 'nelmio-ua-parser-') |
There was a problem hiding this comment.
Should this not type-hint the interface instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this browser_adaptive feature, I realized it consumes quite a lot of CPU.
This PR decouple analyzer and parser so that cache can be used