Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ExternalRedirectResponse #331

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

martijnc
Copy link
Contributor

@martijnc martijnc commented Dec 8, 2023

Introduces ExternalRedirectResponse to allow redirects to other hosts without the need to configure those hosts globally allowing for more fine-grained control.

Fixes #330.

`ExternalRedirectResponse` allows redirects to other hosts without the need to configure those hosts globally.
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da7cc88) 96.93% compared to head (7476be6) 96.94%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #331      +/-   ##
============================================
+ Coverage     96.93%   96.94%   +0.01%     
- Complexity      429      433       +4     
============================================
  Files            52       53       +1     
  Lines          1923     1933      +10     
============================================
+ Hits           1864     1874      +10     
  Misses           59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ran PHP CS autofixer.
@martijnc
Copy link
Contributor Author

Is the project interested in a feature like this? Is there anything I can help with to get this merged? Thanks!

@yellow1912
Copy link

I'm very much interested to see this merged

@Seldaek Seldaek merged commit 6a6c75e into nelmio:master Apr 10, 2024
@martijnc martijnc deleted the feature/external-redirect-response branch May 31, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce ExternalRedirectResponse for more fine-grained redirection control
4 participants