Support Symfony 7 #1145
Closed
Support Symfony 7 #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,20 +24,20 @@ | |||
| "fakerphp/faker": "^1.10", | |||
| "myclabs/deep-copy": "^1.10", | |||
| "sebastian/comparator": "^3.0 || ^4.0 || ^5.0", | |||
| "symfony/property-access": "^5.4 || ^6.0", | |||
| "symfony/yaml": "^5.4 || ^6.0" | |||
| "symfony/property-access": "^5.4 || ^6.0 || ^7.0", | |||
There was a problem hiding this comment.
What about changing ^6.0 to ^6.4 in order to only support the LTS versions and the last release?
It may be done on another PR though.
There was a problem hiding this comment.
@theofidry What do you prefer?
There was a problem hiding this comment.
I think it's a good idea, but definitely in a different PR. I think it would also make sense to drop 5.4, maintaining 3 different versions is too much IMO
theofidry
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Thanks for the PR! The other changes can be done separately, but I think it would be good to have at least one job where Symfony 7 is forced: https://github.com/nelmio/alice/blob/master/.github/workflows/ci.yaml#L23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Symfony 7