Prepare for PHP7.2 #708
Merged
Prepare for PHP7.2 #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
requested changes
Mar 23, 2017
| @@ -45,6 +45,12 @@ public function getValue() | |||
| public function valueMatches($regex) | |||
| { | |||
| if (preg_match($regex, $this->value, $matches)) { | |||
| $matches = array_map( | |||
There was a problem hiding this comment.
if the preg_match change is deprecated I would not change that yet, it wouldn't be the first time such things are reverted and I didn't see much discussion in php/php-src#1303.
There was a problem hiding this comment.
I'll remove this, it will result in a failing nightly branch for now. When PHP decides to be BC again the branch should turn green (on a rebuild)
| if (!is_array($args)) { | ||
| throw new \UnexpectedValueException("The static '{$method}' call in object '{$this}' must be given an array"); | ||
| foreach ($constructorValue as $method => $args) { | ||
|
|
| "Cannot call static method '{$method}' on class '{$this->class}' as a constructor for object '{$this}'" | ||
| ); | ||
| } | ||
| if (!is_array($args)) { |
There was a problem hiding this comment.
while we are at it let's add a blank line here between the two if :)
* Run composer with --ignore-platform-reqs for nightly * Run composer with weak deprecation warnings (PHPUnint still uses each()) * Rewrote usage of each() (which is deprecated in PHP7.2) * `preg_match` returns `NULL` instead of `''` since PHP7.2
theofidry
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preg_matchreturnsNULLinstead of''since PHP7.2