Combine string token followed by reference #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👌 Do you mind to add a small integration test? You'll need to add it in both |
theofidry
changed the title
|
Added integration tests. I wasn't exactly sure what to name the scenarios or where to place them in the data provider though. |
|
Not sure why the lexer test is failing in the Symfony run on Travis. |
|
This indeed looks very weird, can you reproduce it locally (try |
|
Yea I just got it to error locally with Edit: Think I got it. The new lexer needed to be setup in the lexer chain in the Symfony DIC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #780