Add Symfony Yaml PHP constants support integration (2.x) #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
force-pushed
the
yaml-php-constant
branch
from
09214f5
to
8e96134
Compare
Ref: http://symfony.com/blog/new-in-symfony-3-2-php-constants-in-yaml-files This addition is backward compatible as the Yaml flag will be used only if it is defined.
soullivaneuh
force-pushed
the
yaml-php-constant
branch
from
8e96134
to
59ad107
Compare
|
According to your requirement:
I'll cherry-pick it on master right now. 👍 |
soullivaneuh
changed the title
|
See #829 for master. |
|
👍 I'll merge both of them at the same time, thanks :) |
|
Thanks for the merge. 👍 Can you please make a new release for that? |
|
yep, done |
|
Thanks, it works like a charm! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #827
@theofidry How do you want to backport this to master? Will you do a manual merge? Would you like me to cherry-pick this feature on an another PR?