Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed use of self to static to allow for easier extension #976

Merged
merged 1 commit into from Feb 28, 2019
Merged

Changed use of self to static to allow for easier extension #976

merged 1 commit into from Feb 28, 2019

Conversation

Bittarman
Copy link
Contributor

Changed FakerGeneratorFactory::create calls use of LOCALE constant from self to static to allow for easier overriding

@Bittarman
Changed use of self to static to allow for easier extension
b606612 
Changed FakerGeneratorFactory::create calls use of LOCALE constant from self to static to allow for easier overriding
@theofidry theofidry merged commit a14e893 into nelmio:master Feb 28, 2019
@theofidry
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bittarman @theofidry