Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexibleSslListener secure remember me not working #3

Closed
kbond opened this issue Dec 13, 2011 · 6 comments
Closed

FlexibleSslListener secure remember me not working #3

kbond opened this issue Dec 13, 2011 · 6 comments

Comments

@kbond
Copy link
Contributor

kbond commented Dec 13, 2011

As far as I can tell this feature is not working. The remember me cookie remains unsecure.

@igorw
Copy link
Contributor

igorw commented Dec 13, 2011

Confirmed, looking into it. Thanks!

@igorw
Copy link
Contributor

igorw commented Dec 13, 2011

This can be configured at the firewall level as follows:

security:
    firewalls:
        main:
            remember_me:
                key:      aSecretKey
                lifetime: 3600
                path:     /
                domain:   ~
                secure: true

So I'm not sure we even have to take care of it. Jordi?

@dustin10
Copy link

@igorw There is also this. Although, I'm not sure if requires_channel is only used in matching or if it will do the switch.

@Seldaek
Copy link
Member

Seldaek commented Dec 19, 2011

@dustin10: As far as I know it only matches (or does not match).

@Seldaek
Copy link
Member

Seldaek commented Dec 19, 2011

@igorw @kbond I still think we should fix it, this basically should enforce the core config to do secure remember-me cookies.

@Seldaek Seldaek closed this as completed in 647571b Jan 8, 2013
@Seldaek
Copy link
Member

Seldaek commented Jan 8, 2013

OK I finally looked into this and now it will really force every new cookie set in the login request to be secure (except the auth one from this bundle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants