Remove detach from the frontend (codalab#2427)

* clear force delete bit * remove detach from frontend * remove constant
nelson-liu · Jun 19, 2020 · 2e8a72a · 2e8a72a
1 parent abd8cf1
commit 2e8a72a
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 49 deletions.
diff --git a/frontend/src/components/worksheets/BundleBulkActionMenu.js b/frontend/src/components/worksheets/BundleBulkActionMenu.js
@@ -37,16 +37,6 @@ class BundleBulkActionMenu extends React.Component {
                     <DeleteForeverIcon fontSize='small' />
                     <Typography variant='inherit'>Delete</Typography>
                 </Button>
-                <Button
-                    size='small'
-                    color='inherit'
-                    aria-label='Detach'
-                    disabled={!this.props.editPermission}
-                    onClick={this.props.toggleCmdDialog('detach')}
-                >
-                    <ExitToAppIcon fontSize='small' />
-                    <Typography variant='inherit'>Detach</Typography>
-                </Button>
                 <Button
                     size='small'
                     color='inherit'

diff --git a/frontend/src/components/worksheets/Worksheet/Worksheet.js b/frontend/src/components/worksheets/Worksheet/Worksheet.js
@@ -354,8 +354,6 @@ class Worksheet extends React.Component {
         }
         if (cmd_type === 'rm') {
             this.setState({ openedDialog: DIALOG_TYPES.OPEN_DELETE_BUNDLE });
-        } else if (cmd_type === 'detach') {
-            this.setState({ openedDialog: DIALOG_TYPES.OPEN_DETACH });
         } else if (cmd_type === 'kill') {
             this.setState({ openedDialog: DIALOG_TYPES.OPEN_KILL });
         } else if (cmd_type === 'copy' || cmd_type === 'cut') {
@@ -432,8 +430,6 @@ class Worksheet extends React.Component {
             return true;
         } else if (this.state.openedDialog === DIALOG_TYPES.OPEN_DELETE_BUNDLE) {
             this.executeBundleCommandNoEvent('rm');
-        } else if (this.state.openedDialog === DIALOG_TYPES.OPEN_DETACH) {
-            this.executeBundleCommandNoEvent('detach');
         } else if (this.state.openedDialog === DIALOG_TYPES.OPEN_KILL) {
             this.executeBundleCommandNoEvent('kill');
         }
@@ -938,16 +934,6 @@ class Worksheet extends React.Component {
                     }
                     this.toggleCmdDialogNoEvent('rm');
                 });
-                // Consider deprecating detach from the frontend
-                Mousetrap.bind(['a D'], () => {
-                    if (
-                        this.state.openedDialog &&
-                        this.state.openedDialog !== DIALOG_TYPES.OPEN_DETACH
-                    ) {
-                        return;
-                    }
-                    this.toggleCmdDialogNoEvent('detach');
-                });
                 Mousetrap.bind(['a k'], () => {
                     if (
                         this.state.openedDialog &&
@@ -973,8 +959,6 @@ class Worksheet extends React.Component {
                                 this.executeBundleCommandNoEvent('rm');
                             } else if (this.state.openedDialog === DIALOG_TYPES.OPEN_KILL) {
                                 this.executeBundleCommandNoEvent('kill');
-                            } else if (this.state.openedDialog === DIALOG_TYPES.OPEN_DETACH) {
-                                this.executeBundleCommandNoEvent('detach');
                             }
                         }.bind(this),
                     );

diff --git a/frontend/src/components/worksheets/WorksheetDialogs.js b/frontend/src/components/worksheets/WorksheetDialogs.js
@@ -77,28 +77,6 @@ class WorksheetDialogs extends React.Component {
                         </Button>
                     </DialogActions>
                 </Dialog>
-                <Dialog
-                    open={this.props.openedDialog === DIALOG_TYPES.OPEN_DETACH}
-                    onClose={this.props.closeDialog}
-                    aria-labelledby='detach-confirmation-title'
-                    aria-describedby='detach-confirmation-description'
-                >
-                    <DialogTitle id='detach-confirmation-title'>
-                        {'Detach selected bundles from this worksheet?'}
-                    </DialogTitle>
-                    <DialogActions>
-                        <Button color='primary' onClick={this.props.closeDialog}>
-                            CANCEL
-                        </Button>
-                        <Button
-                            color='primary'
-                            variant='contained'
-                            onClick={this.props.executeBundleCommand('detach')}
-                        >
-                            DETACH
-                        </Button>
-                    </DialogActions>
-                </Dialog>
                 <Dialog
                     open={this.props.openedDialog === DIALOG_TYPES.OPEN_KILL}
                     onClose={this.props.closeDialog}

diff --git a/frontend/src/constants.js b/frontend/src/constants.js
@@ -13,7 +13,6 @@ export const LOCAL_STORAGE_WORKSHEET_WIDTH = 'worksheetWidth';
 // Dialog constants
 export const DIALOG_TYPES = {
     OPEN_DELETE_BUNDLE: 'delete_bundle',
-    OPEN_DETACH: 'detach_bundle',
     OPEN_KILL: 'kill_bundle',
     OPEN_DELETE_MARKDOWN: 'delete_markdown_block',
     OPEN_DELETE_WORKSHEET: 'delete_whole_worksheet',