Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SIGKILL signal handling by SIGTERM and SIGINT #3

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

ssideleau
Copy link
Contributor

Trying to listen for the SIGKILL IPC signal results in a uv_signal_start EINVAL error.

According to nodejs documentation on signal events:

'SIGKILL' cannot have a listener installed, it will unconditionally terminate Node.js on all platforms.

Listening on SIGINT (ctrl + c) and SIGTERM should be enough to terminate the sort process gracefully.

Thank you for the library it works great once that bug is taken out of the equation.

@nelson-perez
Copy link
Owner

Thanks for the change.

@nelson-perez nelson-perez merged commit 79ab104 into nelson-perez:main Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants