Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea - Lorin melee change #179

Open
ForestDragon-wesnoth opened this issue Feb 13, 2024 · 7 comments · May be fixed by #194
Open

idea - Lorin melee change #179

ForestDragon-wesnoth opened this issue Feb 13, 2024 · 7 comments · May be fixed by #194
Assignees
@cooljeanius
Labels
enhancement New feature or request
Milestone
1.7.0

Comments

@ForestDragon-wesnoth
Copy link

on lvl1 Lorin has a 5-strike attack, but on lvl2-3 her attack is a 4-strike one, even though it's much stronger but still
current progression is 5-5 > 11-4 > 13-4
maybe something like 5-5 > 8-5 > 11-5 would make more sense
@cooljeanius cooljeanius added the enhancement New feature or request label Feb 13, 2024
@cooljeanius
Copy link
Collaborator

I think the current setup is due to her AMLAs that increase the strike count... @nemaara WDYT?

@nemaara
Copy link
Owner

nemaara commented Feb 13, 2024

maybe lvl 1 should be 6-4 or sth?

@cooljeanius
Copy link
Collaborator

maybe lvl 1 should be 6-4 or sth?

Yeah, I guess that could work... I kinda wish we could confirm with szopen first as to whether the existing RiPLiB violation is intentional or not (maybe to represent Lorin aging?), but he hasn't really been seen lately...

@nemaara
Copy link
Owner

nemaara commented Feb 18, 2024

Gameplay over lore always.

@ForestDragon-wesnoth
Copy link
Author

ForestDragon-wesnoth commented Feb 18, 2024 •
edited
Loading

Yeah, I guess that could work... I kinda wish we could confirm with szopen first as to whether the existing RiPLiB violation is intentional or not (maybe to represent Lorin aging?)

considering she regains a 5-th strike via AMLA, that seems unlikely

@cooljeanius
Copy link
Collaborator

ok, so I'll try making the "6-4 for L1" change and test that in my next playthru...

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Feb 19, 2024
@cooljeanius
address some feedback from ForestDragon
b42b801 
(untested)
see nemaara/A_New_Order#178 and nemaara/A_New_Order#179
cc @ForestDragon-wesnoth
@cooljeanius
Copy link
Collaborator

one thing I remembered when testing cooljeanius/A_New_Order@b42b801 is that I gave Lorin the "Strong" trait on EASY, so it's actually 7-4 there...

cooljeanius added a commit to cooljeanius/A_New_Order-1 that referenced this issue Apr 2, 2024
@cooljeanius
Preparing for another PR
7861fe3 
- Another attempt at fixing #23 again; cc @Toranks and @knyghtmare
- Refer to Gawen as "Haldric" in S08 for nemaara#182
- Dune is probably ok to reference explicitly by name in the translators' comments
- try Lorin stat changes suggested in nemaara#179
@cooljeanius cooljeanius added this to the 1.7.0 milestone Apr 7, 2024
@cooljeanius cooljeanius self-assigned this Apr 7, 2024
@cooljeanius cooljeanius linked a pull request May 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooljeanius cooljeanius

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Fixes for issues targeted for Milestone 1.7.0 cooljeanius/A_New_Order-1
3 participants
@cooljeanius @nemaara @ForestDragon-wesnoth