Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Battle of Barnon: improve code surrounding Uri's [leader_goal] #30

Closed
cooljeanius opened this issue Oct 12, 2021 · 4 comments · Fixed by #43
Closed

Battle of Barnon: improve code surrounding Uri's [leader_goal] #30

cooljeanius opened this issue Oct 12, 2021 · 4 comments · Fixed by #43
Labels
enhancement New feature or request
Milestone
1.4.1

Comments

@cooljeanius
Copy link
Collaborator

On turns 15 to 30, Uri Van Roe has a [leader_goal] tag directing him to move towards Gawen's keep. However, there is no dialogue indicating that he's going to start doing this, nor is there any dialogue once he's gotten there, which can lead to player confusion as to why he's suddenly acting "suicidal" (seemingly - he has events to guard him, though). More code and dialogue should be added to explain why he's moving and when he's stopped. He could also be protected a bit better.
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Dec 4, 2021
@cooljeanius
First Battle of Barnon playthru on 1.16
7603915 
add dialogue about Uri van Roe's leader_goal; see nemaara/A_New_Order#30
Also break up some dialogue for nemaara/A_New_Order#18
@cooljeanius
Copy link
Collaborator Author

Another thing to do here: protect him better! For example, move the reinforcements he calls in his events to wherever he is. And maybe give him a healer (or two), too.

@cooljeanius
Copy link
Collaborator Author

Another thing to do here: protect him better! For example, move the reinforcements he calls in his events to wherever he is. And maybe give him a healer (or two), too.

ok this part is done as of cooljeanius/A_New_Order@264a8d3

cooljeanius referenced this issue in cooljeanius/A_New_Order Mar 9, 2022
@cooljeanius
ok done playing thru both routes of Barnon
264a8d3 
on 1.16, that is
cooljeanius referenced this issue in cooljeanius/A_New_Order-1 Mar 25, 2022
@cooljeanius
additional work porting to BfW 1.16
c8087e8 
This ought to be equivalent to cooljeanius/A_New_Order@43565fe..44013a3
Bugs addressed, in order of the commits in my repo addressing them:
Addresses #16 (doesn't fix it entirely, though)
Closes #30
Closes #18
Closes #15
Closes #31
Closes cooljeanius/A_New_Order#12
Doesn't actually do anything about #24, despite adding a comment referring to it
Closes #39
Doesn't really do anything about #19, despite adding comments referring to it
@cooljeanius cooljeanius mentioned this issue Mar 25, 2022
Merged
@cooljeanius
Copy link
Collaborator Author

Another thing to do here: protect him better! For example, move the reinforcements he calls in his events to wherever he is. And maybe give him a healer (or two), too.

ok this part is done as of cooljeanius/A_New_Order@264a8d3

...which is now part of PR #43

@cooljeanius cooljeanius mentioned this issue Mar 29, 2022
Closed
@cooljeanius
Copy link
Collaborator Author

this issue apparently still exists in the form of #46, but instead of reopening this bug, we'll just continue to track it there

@cooljeanius cooljeanius added the enhancement New feature or request label May 29, 2022
@cooljeanius cooljeanius added this to the 1.4.1 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

additional work porting to BfW 1.16 cooljeanius/A_New_Order-1
1 participant
@cooljeanius