{CHECK_EVEN}/{IF_EVEN}/{IF_ODD} macros are broken

[cooljeanius]

So, I first noticed this when trying to use the macros in S04 (Battle of Barnon), but it's a more generic issue than that if you look at how the macros are actually implemented:

A_New_Order/macros/programming-macros.cfg

Lines 277 to 303 in 507890a

	#-------------------------------------------------------------------------------
	# {IF_EVEN <numeric-variable>}
	# {IF_ODD <numeric-variable>}
	#define CHECK_EVEN N
	{SET temp_a {N}}
	{SET temp_b {N}}
	{INCREMENT temp_a}
	{MULTIPLY temp_a .5}
	{MULTIPLY temp_b .5}
	{IF temp_a equals $temp_b}
	{SET_TRUE global_var__is_even}
	{ELSE}
	{SET_FALSE global_var__is_even}
	{END_IF}
	{RELEASE temp_a}
	{RELEASE temp_b}
	#enddef
	#define IF_EVEN N
	{CHECK_EVEN {N}}
	{IF_TRUE global_var__is_even}
	# no good place to deallocate 'global_var__is_even'.
	#enddef
	#define IF_ODD N
	{CHECK_EVEN {N}}
	{IF_FALSE global_var__is_even}
	# no good place to deallocate 'global_var__is_even'.
	#enddef

I mean, seriously? Why did szopen do it like that? Why not just use a modulo?

[soliton-]

Well, modulo support was added at the end of 2006 and ANO was first published in mid 2005.

[Elvish-Hunter]

A quick search shows that {IF_ODD} and {IF_EVEN} are used only in one scenario and {CHECK_EVEN} is just a dependency for these two macros.
If that's OK, I'll prepare a small pull request to update this ancient code.

[cooljeanius]

A quick search shows that {IF_ODD} and {IF_EVEN} are used only in one scenario and {CHECK_EVEN} is just a dependency for these two macros. If that's OK, I'll prepare a small pull request to update this ancient code.

It's definitely okay; please do!

[cooljeanius]

I confirmed that #121 fixes this; thanks @Elvish-Hunter for the PR!