Fix Reumario loyal and simplified code #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A_New_Order/macros/elvish_macros.cfg Line 80 in d4c0d74 A_New_Order/macros/elvish_macros.cfg Line 97 in d4c0d74 This must be changed too, because uses the same method. Same on 10 Siege of Haeltin. All of these show this message in debug mode, because they use a deprecated method:
|
cooljeanius
reviewed
Feb 28, 2023
cooljeanius
reviewed
Feb 28, 2023
| [filter] | ||
| {OP}={WHAT} | ||
| side=1 | ||
| [/filter] | ||
| [/store_unit] | ||
| {TRAIT_LOYAL} |
There was a problem hiding this comment.
remember to follow wmlindent's indentation rules
There was a problem hiding this comment.
Yes, I'll run wmlindent when I finish to test all of this
Yeah some things to remember here are:
|
Merged
|
Closed. Continues here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the weirdest unit modifications I've ever seen xD
Storing unit, directly modifying variables, and unstoring unit? All of this completely unnecessary and makes the trait "loyal" non translatable.
I've done all the changes with [modify_unit] and [transform_unit] without storing anything, much cleaner. I've simplified other parts of the code too, as the [allow_recruit] using comma list instead of repeat every time.