Fix loyalty check in S02 for issue #23

[cooljeanius]

I wrote the existing loyalty check for BfW 1.14. Conversation with @CelticMinstrel (and checking the wiki) reminded me that upkeep="loyal" can go directly into a SUF now, as of BfW 1.15.3, so we can just use that.
Closes issue #23.

[Toranks]

Wait. IIRC @knyghtmare and me found that upkeep=loyal tested positive on level 0 units because 0, free and loyal are synonymous on upkeep. So, your old method must be more reliable.
This is what we are using on UnitMarker now:

[have_unit]
	x,y=$x1,$y1
	side=$side_number
	upkeep=loyal
	[not]
		level=0
	[/not]
[/have_unit]
[or]
	[have_unit]	
		x,y=$x1,$y1
		side=$side_number
		[filter_wml]
			[modifications]
				[trait]
					[effect]
						apply_to=overlay
						add="misc/loyal-icon.png"
					[/effect]
				[/trait]
			[/modifications]
		[/filter_wml]
	[/have_unit]
[/or]

[cooljeanius]

Wait. IIRC @knyghtmare and me found that upkeep=loyal tested positive on level 0 units because 0, free and loyal are synonymous on upkeep. So, your old method must be more reliable. This is what we are using on UnitMarker now:

[have_unit]
	x,y=$x1,$y1
	side=$side_number
	upkeep=loyal
	[not]
		level=0
	[/not]
[/have_unit]
[or]
	[have_unit]	
		x,y=$x1,$y1
		side=$side_number
		[filter_wml]
			[modifications]
				[trait]
					[effect]
						apply_to=overlay
						add="misc/loyal-icon.png"
					[/effect]
				[/trait]
			[/modifications]
		[/filter_wml]
	[/have_unit]
[/or]

aaaahhhhh that looks complicated... can you test and see if that works here?

[cooljeanius]

uh... ok, I guess if you come up with a better solution, @Toranks, you can submit a separate PR

[cooljeanius]

uh... ok, I guess if you come up with a better solution, @Toranks, you can submit a separate PR

...actually, I might have to do this myself...

[cooljeanius]

I wrote the existing loyalty check for BfW 1.14. Conversation with @CelticMinstrel (and checking the wiki) reminded me that upkeep="loyal" can go directly into a SUF now, as of BfW 1.15.3, so we can just use that. Closes issue #23.

@CelticMinstrel it looks like this doesn't actually work; it will fire when inapplicable, and the validator complains about it

[cooljeanius]

I wrote the existing loyalty check for BfW 1.14. Conversation with @CelticMinstrel (and checking the wiki) reminded me that upkeep="loyal" can go directly into a SUF now, as of BfW 1.15.3, so we can just use that. Closes issue #23.

@CelticMinstrel it looks like this doesn't actually work; it will fire when inapplicable, and the validator complains about it

I reopened #23 due to this; cc @knyghtmare