Removed all redundant {IS_LOYAL} #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, as of 1.16, it includes it now, but it didn't in previous versions. But yeah, I guess since we only support 1.16 and newer, it can be removed now.
I think it's worth it for flavor purposes, just to show he's subordinate to Grekulak. But the icon is a fair point though, so if you want to remove that you can just do the |
|
@nemaara do you think this is worth merging? |
nemaara
approved these changes
Mar 31, 2023
cooljeanius
added a commit
to cooljeanius/A_New_Order
that referenced
this pull request
Mar 31, 2023
no longer necessary as of BfW 1.16; see nemaara/A_New_Order#123 by @Toranks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{IS_LOYAL} is used to set the icon and nothing else. Since TRAIT_LOYAL already includes it, it is redundant. This doesn't solve anything, it just simplifies the code. I saw this while fixing the other loyal.
I also include a redundant loyal trait on Mal-Raylal, that is a faction leader. Leaders are always loyal, and the superimposed icon is solved too. I'm adding it here because I realized after the PR that fixes all icons.