Guard against JS error by rendering arrows only if needed

nemccarthy · May 6, 2015 · 3c0d4f0 · 3c0d4f0
1 parent f23e15b
commit 3c0d4f0
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js b/core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
@@ -334,11 +334,13 @@ function drawCrossStageEdges(edges, svgContainer) {
   }
   // Now draw the arrows by borrowing the arrow marker generated by dagre-d3
   var dagreD3Marker = svgContainer.select("g.edgePaths marker").node();
-  svgContainer
-    .append(function() { return dagreD3Marker.cloneNode(true); })
-    .attr("id", "marker-arrow")
-  svgContainer.selectAll("g > path").attr("marker-end", "url(#marker-arrow)");
-  svgContainer.selectAll("g.edgePaths def").remove(); // We no longer need these
+  if (!dagreD3Marker.empty()) {
+    svgContainer
+      .append(function() { return dagreD3Marker.cloneNode(true); })
+      .attr("id", "marker-arrow")
+    svgContainer.selectAll("g > path").attr("marker-end", "url(#marker-arrow)");
+    svgContainer.selectAll("g.edgePaths def").remove(); // We no longer need these
+  }
 }
 
 /*