rename json files to avoid strange file names and not look like php

core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala

@@ -134,7 +134,7 @@ class HistoryServerSuite extends FunSuite with BeforeAndAfter with Matchers with
       errOpt should be (None)
       val json = jsonOpt.get
       val exp = IOUtils.toString(new FileInputStream(
-        new File(expRoot, path + "/json_expectation")))
+        new File(expRoot, HistoryServerSuite.sanitizePath(path) + "/expectation.json")))
       // compare the ASTs so formatting differences don't cause failures
       import org.json4s._
       import org.json4s.jackson.JsonMethods._
@@ -204,9 +204,9 @@ class HistoryServerSuite extends FunSuite with BeforeAndAfter with Matchers with
 
   def generateExpectation(path: String): Unit = {
     val json = getUrl(path)
-    val dir = new File(expRoot, path)
+    val dir = new File(expRoot, HistoryServerSuite.sanitizePath(path))
     dir.mkdirs()
-    val out = new FileWriter(new File(dir, "json_expectation"))
+    val out = new FileWriter(new File(dir, "expectation.json"))
     out.write(json)
     out.close()
   }
@@ -237,19 +237,29 @@ object HistoryServerSuite {
     val code = connection.getResponseCode()
     val inString = try {
       val in = Option(connection.getInputStream())
-      in.map{IOUtils.toString}
+      in.map {
+        IOUtils.toString
+      }
     } catch {
       case io: IOException => None
     }
     val errString = try {
       val err = Option(connection.getErrorStream())
-      err.map{IOUtils.toString}
+      err.map {
+        IOUtils.toString
+      }
     } catch {
       case io: IOException => None
     }
     (code, inString, errString)
   }
 
+
+  def sanitizePath(path: String): String = {
+    // this doesn't need to be perfect, just good enough to avoid collisions
+    path.replaceAll("""\?""", "__q__").replaceAll("=","__e__")
+  }
+
   def getUrl(path: URL): String = {
     val (code, resultOpt, error) = getContentAndCode(path)
     if (code == 200) {