Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex for extract a version from a branch name is too restrictive #1323

Closed
dcoraboeuf opened this issue Jul 10, 2024 · 2 comments
Closed

Regex for extract a version from a branch name is too restrictive #1323

dcoraboeuf opened this issue Jul 10, 2024 · 2 comments
Labels
status:released Issue released and available templating type: bug Defect issue
Milestone
4.8

Comments

@dcoraboeuf
Copy link
Contributor

When using ${branch.version} in a template, and if the branch name is for example release/99999.51, the regex being used is way too restrictive.

Expected result: 99999.51

Returning: 9.51

This is a defect on top of #1321
@dcoraboeuf dcoraboeuf mentioned this issue Jul 10, 2024
Closed
@dcoraboeuf dcoraboeuf added the status:wip Issue being currently worked on label Jul 10, 2024
@dcoraboeuf dcoraboeuf added this to the 4.8 milestone Jul 10, 2024
dcoraboeuf added a commit that referenced this issue Jul 10, 2024
@dcoraboeuf
#1323 Fixing regex for extracting version from branch names
6ef05b7
@dcoraboeuf dcoraboeuf added status:ready Issue merged in release branch, not released yet and removed status:wip Issue being currently worked on labels Jul 10, 2024
@dcoraboeuf
Copy link
Contributor Author

Available in 4.8.86

@dcoraboeuf dcoraboeuf added status:released Issue released and available and removed status:ready Issue merged in release branch, not released yet labels Jul 10, 2024
@dcoraboeuf
Copy link
Contributor Author

Available in 4.9.2

dcoraboeuf added a commit that referenced this issue Jul 11, 2024
@dcoraboeuf
#1323 Search box in search page
9b6b190
dcoraboeuf added a commit that referenced this issue Jul 12, 2024
@dcoraboeuf
#1323 Fixing tests
0b9ac57
dcoraboeuf added a commit that referenced this issue Jul 12, 2024
@dcoraboeuf
#1323 Fixing tests
4a12c3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:released Issue released and available templating type: bug Defect issue
Projects
None yet
Milestone
4.8
Development

No branches or pull requests
1 participant
@dcoraboeuf