Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiFi] implement saved networks #15

Merged
merged 1 commit into from Dec 12, 2018
Merged

[WiFi] implement saved networks #15

merged 1 commit into from Dec 12, 2018

Conversation

akaWolf
Copy link
Contributor

@akaWolf akaWolf commented Dec 11, 2018

No description provided.

neochapay
neochapay reviewed Dec 11, 2018
View reviewed changes
qml/plugins/wifi/NetworkDelegate.qml Outdated
height: parent.height
Image{
id: removeNetworkButton
source: "../../img/trash.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use absolute file patch plz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 11, 2018
View reviewed changes
qml/plugins/wifi/NetworkDelegate.qml Outdated
}

Image{
source: "../../img/disconnect.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 11, 2018
View reviewed changes
qml/plugins/wifi/NetworkDelegate.qml Outdated
source: "../../img/disconnect.svg"
visible: (modelData.state == "online" || modelData.state == "ready")

width: 64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use adaptive sizes. This https://github.com/nemomobile/qtquickcontrols-nemo/blob/master/src/controls/theme.cpp#L17 will be help for you. Use Theme.someSize value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 11, 2018
View reviewed changes
qml/plugins/wifi/wifi.qml Outdated
spacing: 10

Text{
text: "Saved"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qsTr ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@akaWolf akaWolf force-pushed the master branch 3 times, most recently from 01a996c to 5f32357 Compare December 11, 2018 14:39
neochapay
neochapay reviewed Dec 11, 2018
View reviewed changes
qml/plugins/wifi/wifi.qml Outdated

Text{
text: qsTr("Saved")
color: "white"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme.textColor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 11, 2018
View reviewed changes
qml/plugins/wifi/wifi.qml Outdated

Text{
text: qsTr("Enabled")
color: "white"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme.textColor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@akaWolf akaWolf force-pushed the master branch 2 times, most recently from d05d19b to 5b4dc8a Compare December 11, 2018 15:10
neochapay
neochapay reviewed Dec 12, 2018
View reviewed changes
qml/plugins/wifi/WifiSettings.qml Outdated
id: passphrase
text: modelData.passphrase
}

Button {
Button{
id: connectButton
height: 48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme.size ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 12, 2018
View reviewed changes
qml/plugins/wifi/WifiStatus.qml Outdated
@@ -109,7 +106,6 @@ Page {
}
}


Row{
spacing: 24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme.size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 12, 2018
View reviewed changes
qml/plugins/wifi/wifi.qml Outdated
width: parent.width-size.dp(40)
height: parent.height-actionColumn.height-size.dp(80)
contentHeight: networks.height+50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size.dp(50)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 12, 2018
View reviewed changes
qml/plugins/wifi/wifi.qml Outdated
Text{
text: qsTr("Saved")
color: Theme.textColor
font.pointSize: 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme.size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 12, 2018
View reviewed changes
qml/plugins/wifi/wifi.qml Outdated
}
Column{
id: networks
spacing: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme.size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

neochapay
neochapay reviewed Dec 12, 2018
View reviewed changes
qml/plugins/wifi/wifi.qml Outdated
Text{
text: qsTr("Enabled")
color: Theme.textColor
font.pointSize: 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme.size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@akaWolf akaWolf force-pushed the master branch 5 times, most recently from 2f3b2e6 to 22813d2 Compare December 12, 2018 11:58
@neochapay
Copy link
Member

LGTM

@neochapay neochapay merged commit 1485045 into nemomobile-ux:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neochapay neochapay neochapay left review comments

@alekseysidorov alekseysidorov alekseysidorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akaWolf @neochapay @alekseysidorov