[carddav] Add CardDAV sync plugin code #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // now update our id mapping in case anything changed. | ||
| // this is necessary especially for added contacts, which previously had no id. | ||
| Q_FOREACH (const QContact &c, addMod) { | ||
| if (c.id().isNull()) { |
There was a problem hiding this comment.
I'm hitting this in my testing. Not sure why this is happening, or what can cause it to occur.
There was a problem hiding this comment.
Ah, this could happen because removed contacts didn't have their ids set correctly, previously (I had been clearing the m_contactIds[guid] value before returning the AMR set to the syncer.cpp code, which meant that we couldn't set a real id in Removed contacts). Fixed now.
|
LGTM |
This commit adds support for CardDAV sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for CardDAV sync