[lipstick] devicelock to handle blanking states for home2. Contribute… #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for reviewers: matching changes in jolla-home can be found in "keep-lock"-branch. |
| @@ -31,7 +31,7 @@ BuildRequires: pkgconfig(Qt5Test) | |||
| BuildRequires: pkgconfig(Qt5Sensors) | |||
| BuildRequires: pkgconfig(contentaction5) | |||
| BuildRequires: pkgconfig(mlite5) >= 0.0.6 | |||
| BuildRequires: pkgconfig(mce) >= 1.12.2 | |||
There was a problem hiding this comment.
mce is at 1.51.1, but mce-dev aka mce-headers aka pkgconfig(mce) >= 1.16.0
| @@ -83,6 +120,27 @@ void DeviceLock::handleCallStateChange(const QString &state, const QString &igno | |||
| } | |||
| } | |||
|
|
|||
| void DeviceLock::handleBlankingPauseChange(const QString &state) | |||
| { | |||
| if (state.startsWith("active") && !m_blankingPause) { | |||
There was a problem hiding this comment.
Is there some reason to use startsWith() instead of equality check?
Also I found the double if structure to require some thought to grok. Could be simpler and smaller - something like this perhaps?
bool blankingPause = (state == "active");
if (m_blankingPause != blankingPause ) {
m_blankingPause = blankingPause;
emit blankingPauseChanged();
}
|
I guess the dependency already got fixed, so LGTM |
|
I dont have write access to this repo. So anyone with write access: feel free to merge. |
|
To me feels architecturally weird to give homescreen blanking state handling to device lock. |
|
LGTM |
adenexter
added a commit
that referenced
this pull request
May 26, 2015
[lipstick] devicelock to handle blanking states for home2. Contribute…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to JB#28929