Add ApplicationWindow, ui rotation handling, and update examples accordingly #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may consider renaming the component, but anyway: ApplicationWindow includes a page stack (StackView) which handles the pages of the application. ApplicationWindow includes an Item handling UI rotations, and offers allowedOrientations (and other useful properties) to help the dev handle rotation locking.
|
LGTM, tested too and works quite nicely :) |
| text: "Disabled" | ||
| Text { | ||
| font.pixelSize: 42 | ||
| Behavior on x { NumberAnimation{ easing.type: Easing.OutCubic} } |
There was a problem hiding this comment.
nippik: curly braces' spacing &)
NumberAnimation_{ easing.type: Easing.OutCubic_}
There was a problem hiding this comment.
lol, this is from official code 🎯
https://qt.gitorious.org/qt/qtquickcontrols/source/aacf5e953fedc5a19002078d7a25d0a0a4dcc908:examples/quick/controls/touch/main.qml#L96
|
|
||
| //this shouldn't happen, as orientation 0 is not part of Qt ENUM | ||
| if (!orientationToBeChecked) { | ||
| console.log("Hi! I'm a bug, report me to faenil (trying to set invalid orientation)") |
|
LGTM! |
faenil
added a commit
that referenced
this pull request
Oct 23, 2013
Add ApplicationWindow, ui rotation handling, and update examples accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may consider renaming the component, but anyway:
ApplicationWindow includes a page stack (StackView) which handles
the pages of the application.
ApplicationWindow includes an Item handling UI rotations,
and offers allowedOrientations (and other useful properties)
to help the dev handle rotation locking.