Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statefs erroneously picks the default battery device #16

Closed
martinbrook opened this issue May 4, 2014 · 9 comments
Closed

statefs erroneously picks the default battery device #16

martinbrook opened this issue May 4, 2014 · 9 comments

Comments

@martinbrook
Copy link

On N5 we had to re-apply this code (siteshwar@6badb86) to get battery status.

This code was removed from upstream as it broke other device(s).

upower --dump give the following from some devices

sgs3 - http://pastie.org/9139409
n4 - http://pastie.org/9139402
n5 - http://pastie.org/9138877
jolla - http://pastie.org/9139430

proposal 16:32 < sledges> could we not do binding on "native-path==battery" ?

@deztructor
Copy link
Contributor

Good solution. Will you prepare pull req?

@martinbrook
Copy link
Author

We discussed this in IRC today and this solution was proposed by sledges
but I'd like to talk to alterego and get his agreement as well in case this
solution does not work for Nexus 7, as he was the person who removed this
check I am worried it may break his adaptations.

If he is in agreement I can prepare something.

Does this sound ok?

@deztructor
Copy link
Contributor

Of course, it is better if alterego can check is it working fine there.

@tswindell
Copy link

Looks like it'll work on Nexus 7 as well.
upower --dump here: http://pastie.org/9154006

I shall work on a patch today and submit it for review this afternoon.

@tswindell
Copy link

Created PR for this patch:
#17

@sledges
Copy link
Contributor

sledges commented May 8, 2014

tested on 3 devices and LGTM`d the patch above :) thanks everybuddy!

@deztructor
Copy link
Contributor

patch is merged and tagged in 0.2.55. Please, check is tagged version working fine and close it.

@sledges
Copy link
Contributor

sledges commented May 9, 2014

Just tested on Nexus4 from a generated image. Works oob!

@deztructor
Copy link
Contributor

Thank you! So, closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants