-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statefs erroneously picks the default battery device #16
Comments
Good solution. Will you prepare pull req? |
We discussed this in IRC today and this solution was proposed by sledges If he is in agreement I can prepare something. Does this sound ok? |
Of course, it is better if alterego can check is it working fine there. |
Looks like it'll work on Nexus 7 as well. I shall work on a patch today and submit it for review this afternoon. |
Created PR for this patch: |
tested on 3 devices and LGTM`d the patch above :) thanks everybuddy! |
patch is merged and tagged in 0.2.55. Please, check is tagged version working fine and close it. |
Just tested on Nexus4 from a generated image. Works oob! |
Thank you! So, closing the issue |
On N5 we had to re-apply this code (siteshwar@6badb86) to get battery status.
This code was removed from upstream as it broke other device(s).
upower --dump give the following from some devices
sgs3 - http://pastie.org/9139409
n4 - http://pastie.org/9139402
n5 - http://pastie.org/9138877
jolla - http://pastie.org/9139430
proposal 16:32 < sledges> could we not do binding on "native-path==battery" ?
The text was updated successfully, but these errors were encountered: