Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'tap' of undefined #1

Merged

Conversation

naterkane
Copy link
Contributor

I was running into an issue where I couldn't avoid a type error that said
TypeError: Cannot read property 'tap' of undefined

  • make sure compilation.hooks.htmlWebpackPluginBeforeHtmlProcessing isn't undefined
  • borrow !tapped++ check from another plugin's webpack 4 compatibility update

* make sure compilation.hooks.htmlWebpackPluginBeforeHtmlProcessing isn't undefined
* borrow !tapped++ check from another plugin's webpack4 compatability update
Copy link
Owner

@nenadom nenadom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍

@nenadom nenadom merged commit 0c26abc into nenadom:master Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants