Support unknown sequence lengths in LMUFeedforward #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)keras_lmu/version.py
keras_lmu/layers.py
|
drasmuss
force-pushed
the
flexible-ff
branch
2 times, most recently
from
990def2
to
231ee34
Compare
hunse
reviewed
Apr 26, 2023
The latest cudnn is not compatible with the old nvidia drivers installed in the azure VMs, and we can't update the nvidia drivers without updating the whole OS at this point.
Nothing technically wrong with this, and can be used for skip connections.
Having the memory state come first is more intuitive, as it is both always present and comes first in the computational flow.
tbekolay
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a heuristic of
3*thetafor the impulse response length if the sequence length is unknown.